Skip to content

fix: change TLS client auth default to "none" #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: change TLS client auth default to "none" #5468

merged 2 commits into from
Dec 19, 2022
+2 −2

Conversation

deansheather
Copy link
Member

"request" causes usability issues when it's not necessary:

  • Browsers may prompt the user to select a client certificate
  • iOS returns an error page instead of sending no certificate and loading properly (not sure why or what the conditions are)

@deansheather deansheather requested a review from jsjoeio December 19, 2022 19:01
jsjoeio
jsjoeio approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Safari on macOS and iPadOS ✅

@deansheather deansheather enabled auto-merge (squash) December 19, 2022 19:04
@deansheather deansheather merged commit e359f3c into main Dec 19, 2022
@deansheather deansheather deleted the dean/tls-client-auth-none branch December 19, 2022 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @jsjoeio