fix: use template default ttl when enabling auto-stop #5494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when you enabled auto-stop after it had been disabled, the field was populated with 12 no matter what. Now, it's populated with your template default ttl.
If the template default ttl is 0 (meaning "don't auto-stop"), it will populate 0, but if you try to submit that, you'll get a validation error saying it must be greater than 0 if auto-stop is enabled. This seems like the best way to handle it to me.
I'm going to work on testing later but wanted to get a review started.