Skip to content

chore: Improve project-wide prettier formatting and ignored files #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 3, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Dec 22, 2022

This PR synchronizes our ignore files git/prettier/eslint and provides project-wide prettier settings. It's unfortunate we have to do it this way but I think this is preferable over introducint package.json/prettier in project root.

Noteables:

  • We now lint the whole project (markdown, yaml, json, etc) via prettier
  • .gitignore, .prettierignore.include and .prettierrc.yaml are now the source-of-truth
  • Ignore files are generated with relative paths into site/*

Inspired by recent autofix PRs (cheers @ghuntley).

I recommend reviewing this PR commit-by-commit.

  • chore: Improve project-wide prettier formatting and ignored files
  • chore: Run make fmt/prettier

@mafredri mafredri marked this pull request as ready for review December 22, 2022 14:33
@mafredri mafredri requested a review from a team as a code owner December 22, 2022 14:33
@mafredri mafredri requested review from Kira-Pilot, deansheather, ghuntley and a team and removed request for a team December 22, 2022 14:33
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! ❤️

@mafredri mafredri self-assigned this Dec 22, 2022
@mtojek mtojek self-requested a review January 2, 2023 08:39
@mafredri mafredri merged commit 856f0ab into main Jan 3, 2023
@mafredri mafredri deleted the mafredri/chore-prettier-formatting branch January 3, 2023 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants