Skip to content

feat: add coder.volumes parameter to Helm chart #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2023
Merged

feat: add coder.volumes parameter to Helm chart #5551

merged 3 commits into from
Jan 5, 2023

Conversation

NiklasRosenstein
Copy link
Contributor

This PR adds a coder.kubeConfig parameter to the Helm chart so that we can mount a ~/.kube/config file on the Coder host.

See #5548

@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NiklasRosenstein
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@NiklasRosenstein
Copy link
Contributor Author

recheck

@NiklasRosenstein NiklasRosenstein changed the title add coder.kubeConfig parameter to Helm chart feat: add coder.kubeConfig parameter to Helm chart Jan 3, 2023
@NiklasRosenstein
Copy link
Contributor Author

recheck

@NiklasRosenstein
Copy link
Contributor Author

I don't understand why the CLA Assistant still complains 👀

@kylecarbs
Copy link
Member

@NiklasRosenstein me either... I'll try to rerun ;p

kylecarbs
kylecarbs reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making it completely abstract instead? Allowing an arbitrary set of volumes to mount and secrets to consume.

The rationale is that there are N configurations that could exist for various cloud providers, and it could be weird to support them all with unique keys.

I think having an example with ~/.kube/config would be ideal, though, since that's the primary use case.

Thoughts?

@NiklasRosenstein NiklasRosenstein mentioned this pull request Jan 3, 2023
Closed
@deansheather
Copy link
Member

I have refactored the volumes code in helm recently to support adding different volume types (for certs etc.) which we could expose to the user as a value instead.

coder.extraVolumes and coder.extraVolumeMounts

@NiklasRosenstein
Copy link
Contributor Author

Sounds like a good idea, that's definitely good so you can also deploy AWS credentials, etc.

What's the way to do it without mounting a file? Providing the credentials on coder template push for a sensitive variable?

@deansheather
Copy link
Member

I'll push my volumes idea to your branch so we can get this through.

What's the way to do it without mounting a file? Providing the credentials on coder template push for a sensitive variable?

Yeah, originally our GCP/AWS templates would take credentials as parameters (it was not pretty for google cloud as the credentials are huge JSON objects). You could also use environment variables via coder.env

@deansheather deansheather requested a review from kylecarbs January 5, 2023 05:06
deansheather
deansheather approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to allow arbitrary volumes and volume mounts. Since we just include the raw yaml from the value directly in the template, you can use secrets, config maps, empty dir, etc.

image

@deansheather deansheather requested a review from coadler January 5, 2023 05:23
@deansheather deansheather changed the title feat: add coder.kubeConfig parameter to Helm chart feat: add coder.volumes parameter to Helm chart Jan 5, 2023
@deansheather deansheather merged commit dcf6c20 into coder:main Jan 5, 2023
@deansheather
Copy link
Member

Thank you for your contribution 😄

@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
@NiklasRosenstein NiklasRosenstein deleted the add-kubeConfig-to-helm branch January 5, 2023 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@f0ssel f0ssel f0ssel approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@coadler coadler Awaiting requested review from coadler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NiklasRosenstein @kylecarbs @deansheather @f0ssel