Skip to content

feat: enable enterprise users to specify a custom logo #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jan 4, 2023

This adds a field in deployment settings that allows users to specify the URL to a custom logo that will display in the dashboard.

This also groups service banner into a new appearance settings page. It adds a Fieldset component to allow for modular fields moving forward.

Fixes #5465

The Blockbuster logo overflows a bit because of the height ratio, but I think it looks cool, so I decided not to change it!

image

@kylecarbs kylecarbs self-assigned this Jan 4, 2023
@kylecarbs kylecarbs requested a review from a team as a code owner January 4, 2023 06:18
This adds a field in deployment settings that allows users to specify
the URL to a custom logo that will display in the dashboard.

This also groups service banner into a new appearance settings page.
It adds a Fieldset component to allow for modular fields moving forward.
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. There are a few minor things that I would improve in the UI but I can do this later together with some service banner refactoring.

@kylecarbs kylecarbs merged commit 0dba2de into main Jan 4, 2023
@kylecarbs kylecarbs deleted the branding branch January 4, 2023 21:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom branding
2 participants