Skip to content

fix(ci): fix winget installer workflow #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix(ci): fix winget installer workflow #5569

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0b0d8a
fix(ci): add GH_TOKEN env
matifali Jan 4, 2023
dedff5e
fix(ci): change amd64 to win64 in windows installer
matifali Jan 4, 2023
70e62b7
chore: fix windows installer build filename
deansheather Jan 5, 2023
1348116
fixup! chore: fix windows installer build filename
deansheather Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ci): change amd64 to win64 in windows installer 
wingetcreate specifically checks for 
https://github.com/microsoft/winget-create/blob/7c61f3e877f95f6c8ab60ed4e3a34d9449d7e774/src/WingetCreateCore/Common/PackageParser.cs#L466
to decide on application architecture.
  • Loading branch information
@matifali
matifali authored Jan 4, 2023
commit dedff5e91a08f9ec2b0ea949844ac92a0fe3da44
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
make -j \
build/coder_"$version"_linux_{amd64,armv7,arm64}.{tar.gz,apk,deb,rpm} \
build/coder_"$version"_{darwin,windows}_{amd64,arm64}.zip \
build/coder_"$version"_windows_amd64_installer.exe \
build/coder_"$version"_windows_win64_installer.exe \
build/coder_helm_"$version".tgz
env:
CODER_SIGN_DARWIN: "1"
Expand Down