Skip to content

feat: add more rate limit control flags #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 5, 2023
Merged

feat: add more rate limit control flags #5570

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51c825b
feat: add more rate limit control flags
deansheather Jan 4, 2023
91da46f
feat: add flag to disable all rate limits
deansheather Jan 4, 2023
570431c
Merge branch 'main' into dean/more-rate-limit-flags
deansheather Jan 5, 2023
6b738c3
chore: remove new ratelimit flags
deansheather Jan 5, 2023
fea5eae
fix: add env var override field to deployconfig
deansheather Jan 5, 2023
f3d5166
fixup! fix: add env var override field to deployconfig
deansheather Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix: add env var override field to deployconfig
  • Loading branch information
@deansheather
deansheather committed Jan 5, 2023
commit f3d5166935af8b05080f72b777b994a802a3f96b
5 changes: 4 additions & 1 deletion cli/deployment/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,9 @@ func readSliceFromViper[T any](vip *viper.Viper, key string, value any) []T {

// Ensure the env entry for this key is registered
// before checking value.
//
// We don't support DeploymentConfigField[].EnvOverride for array flags so
// this is fine to just use `formatEnv` here.
vip.MustBindEnv(configKey, formatEnv(configKey))

value := vip.Get(configKey)
Expand Down Expand Up @@ -709,7 +712,7 @@ func setFlags(prefix string, flagset *pflag.FlagSet, vip *viper.Viper, target in

// Allow currently set environment variables
// to override default values in help output.
vip.MustBindEnv(prefix, formatEnv(prefix))
vip.MustBindEnv(prefix, env)

switch value.(type) {
case string:
Expand Down