Skip to content

fix: Remove "coder" user and group from systemd service #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This caused an inability to listen on privileged ports and read certs
from LetsEncrypt. It seems more hurtful rather than helpful, so
removing the restriction seems reasonable.

@kylecarbs kylecarbs requested a review from coadler March 24, 2022 23:50
@kylecarbs kylecarbs self-assigned this Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #559 (c9d4e8d) into main (d371a66) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   63.05%   62.83%   -0.23%     
==========================================
  Files         194      108      -86     
  Lines       11107    10035    -1072     
  Branches       85        0      -85     
==========================================
- Hits         7003     6305     -698     
+ Misses       3348     3003     -345     
+ Partials      756      727      -29     
Flag Coverage Δ
unittest-go- 61.80% <100.00%> (+0.02%) ⬆️
unittest-go-macos-latest 57.35% <71.42%> (-0.22%) ⬇️
unittest-go-ubuntu-latest 60.85% <71.42%> (+0.01%) ⬆️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
cli/start.go 65.84% <100.00%> (+0.82%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
pty/ptytest/ptytest.go 94.82% <0.00%> (-5.18%) ⬇️
cli/projectinit.go 56.36% <0.00%> (-3.64%) ⬇️
provisionerd/provisionerd.go 79.83% <0.00%> (-1.32%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 58.60% <0.00%> (-0.52%) ⬇️
site/src/components/CodeExample/CodeExample.tsx
site/src/app.tsx
site/src/components/Page/Footer.tsx
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d371a66...c9d4e8d. Read the comment docs.

This caused an inability to listen on privileged ports and read certs
from LetsEncrypt. It seems more hurtful rather than helpful, so
removing the restriction seems reasonable.
@kylecarbs kylecarbs enabled auto-merge (squash) March 25, 2022 00:15
@kylecarbs kylecarbs merged commit 39e5fcf into main Mar 25, 2022
@kylecarbs kylecarbs deleted the depfix branch March 25, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants