Skip to content

feat: add storybook for /deployments/general #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2023
Merged

feat: add storybook for /deployments/general #5595

merged 3 commits into from
Jan 5, 2023

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 5, 2023 •
edited
Loading

  • refactor: split GeneralSettings page <> View
  • feat: add story for generalsettingspageview

image

@jsjoeio jsjoeio changed the title jsjoeio/storybook general feat: add storybook for /deployments/general Jan 5, 2023
@jsjoeio jsjoeio self-assigned this Jan 5, 2023
@jsjoeio jsjoeio marked this pull request as ready for review January 5, 2023 19:34
@jsjoeio jsjoeio requested a review from a team as a code owner January 5, 2023 19:34
@jsjoeio jsjoeio requested review from code-asher and removed request for a team January 5, 2023 19:34
code-asher
code-asher approved these changes Jan 5, 2023
View reviewed changes
@jsjoeio @code-asher
Update site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralS…
7928517 
…ettingsPageView.tsx

Co-authored-by: Asher <ash@coder.com>
@jsjoeio jsjoeio enabled auto-merge (squash) January 5, 2023 22:56
@jsjoeio jsjoeio merged commit 59e919a into main Jan 5, 2023
@jsjoeio jsjoeio deleted the jsjoeio/storybook-general branch January 5, 2023 23:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher