Skip to content

feat: add storybook for /deployment/userauth #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 6, 2023

  • refactor: move deploysettingspage to dir
  • refactor: split page/view UserAuthSettings
  • feat: add storybook for user auth

image

@jsjoeio jsjoeio requested a review from a team as a code owner January 6, 2023 21:44
@jsjoeio jsjoeio requested review from presleyp and removed request for a team January 6, 2023 21:44
@jsjoeio jsjoeio self-assigned this Jan 6, 2023
@jsjoeio jsjoeio changed the title jsjoeio/user auth storybook feat: add storybook for /deployment/userauth Jan 6, 2023
@@ -17,6 +17,7 @@ const OptionsTable: React.FC<{
options: Record<string, DeploymentConfigField<Flaggable>>
}> = ({ options }) => {
const styles = useStyles()
console.log(options, "options")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Those keep slipping in. Fixing

@jsjoeio jsjoeio enabled auto-merge (squash) January 9, 2023 15:55
@jsjoeio jsjoeio merged commit 6807ad0 into main Jan 9, 2023
@jsjoeio jsjoeio deleted the jsjoeio/user-auth-storybook branch January 9, 2023 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants