Skip to content

fix(site): changing password no longer silently trims space chars in a password #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix(site): changing password no longer silently trims space chars in a password #5640

merged 2 commits into from
Jan 10, 2023

Conversation

rac2030
Copy link
Contributor

@rac2030 rac2030 commented Jan 9, 2023

Make the form behave the same way as the new user creation form without the trimming listener in password fields.
Bug documented in #5638

@rac2030 rac2030 requested a review from a team as a code owner January 9, 2023 22:05
@rac2030 rac2030 requested review from presleyp and removed request for a team January 9, 2023 22:05
@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

presleyp
presleyp approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks! You can address the pr title issue by adding "fix: " in front of your current title.

@ghuntley ghuntley changed the title Remove OnChange trimming action for password fields fixing #5638 fix(site): remove OnChange trimming action for password fields fixing #5638 Jan 9, 2023
@ghuntley ghuntley changed the title fix(site): remove OnChange trimming action for password fields fixing #5638 fix(site): changing password no longer silently trims space chars in a password Jan 9, 2023
@coadler
Copy link
Contributor

coadler commented Jan 10, 2023

@rac2030 would you mind appeasing the CLA bot? Then we should be good to merge!

@rac2030
Copy link
Contributor Author

rac2030 commented Jan 10, 2023

I have read the CLA Document and I hereby sign the CLA

@rac2030
Copy link
Contributor Author

rac2030 commented Jan 10, 2023

recheck

@rac2030
Copy link
Contributor Author

rac2030 commented Jan 10, 2023

@rac2030 would you mind appeasing the CLA bot? Then we should be good to merge!

Sorry for the delay, had to ensure with my employer that it is fine just to be sure before signing it

@coadler coadler linked an issue Jan 10, 2023 that may be closed by this pull request
When changing a password, it silently trims space characters from inside on every value change trigger #5638
Closed
@coadler coadler merged commit efee03f into coder:main Jan 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
@rac2030 rac2030 deleted the bugfix-5638 branch January 10, 2023 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When changing a password, it silently trims space characters from inside on every value change trigger
3 participants
@rac2030 @coadler @presleyp