Skip to content

test: Use global swagger handler to avoid data race in tests #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

test: Use global swagger handler to avoid data race in tests #5668

merged 1 commit into from
Jan 11, 2023

Conversation

mafredri
Copy link
Member

This PR assigns the swagger http handler via func init so that we can avoid a data race in tests.

Issue: swaggo/http-swagger#78

Race: https://github.com/coder/coder/actions/runs/3888462830/jobs/6635809792

@mafredri mafredri self-assigned this Jan 11, 2023
@mafredri mafredri requested a review from mtojek January 11, 2023 10:22
@mafredri mafredri merged commit 5a3985e into main Jan 11, 2023
@mafredri mafredri deleted the mafredri/test-fix-swaggo-http-race branch January 11, 2023 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek