fix: handle NaN in build time estimate #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Jan 11, 2023
| Math.ceil(dayjs.duration((1 - sinceStart / est) * est).asSeconds()), | ||
| 0, | ||
| ) | ||
| return isNaN(max) ? 0 : max |
There was a problem hiding this comment.
Hmm, looking at the ticket, it seems like this will result in a string saying "Up to 0 seconds remaining" which seems a little off to me. What do you think about adjusting the text for this case so it says something like "Finishing up..." or similar instead?
There was a problem hiding this comment.
It actually hits the case that says "Anytime now..." I added a story called StartingZeroEstimate that should show that.
Kira-Pilot
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5437
If the estimated time left is 0, we divide by 0 and get NaN, and the max of 0 and NaN is NaN, so it takes an extra step to avoid passing NaN on.