Skip to content

ci: Revert to local tag creation and push for releases #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 13, 2023
Merged

ci: Revert to local tag creation and push for releases #5714

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3e00d5
ci: Revert to local tag creation and push for releases
mafredri Jan 13, 2023
104bed6
Whoops
mafredri Jan 13, 2023
8b408d1
Fix continue check and typo
mafredri Jan 13, 2023
79e1e6d
Remove draft env
mafredri Jan 13, 2023
67d100c
Simplify and remove if
mafredri Jan 13, 2023
fcfb50d
Remove increment
mafredri Jan 13, 2023
0c279e3
Update dry-run description
mafredri Jan 13, 2023
ad6eec0
Remove one more instance of draft
mafredri Jan 13, 2023
a521644
Skip watch if dry run
mafredri Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify and remove if
  • Loading branch information
@mafredri
mafredri committed Jan 13, 2023
commit 67d100c3b95a68671e741ff47f86d78f899d2477
10 changes: 3 additions & 7 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ env:

jobs:
release:
name: Create and publish
name: Build and publish
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-16-cores' || 'ubuntu-latest' }}
env:
# Necessary for Docker manifest
Expand All @@ -60,7 +60,6 @@ jobs:
run: git fetch --tags --force

- name: Create release notes
if: ${{ inputs.dry_run }}
env:
# We always have to set this since there might be commits on
# main that didn't have a PR.
Expand All @@ -69,15 +68,12 @@ jobs:
set -euo pipefail
ref=HEAD
old_version="$(git describe --abbrev=0 "$ref^1")"
version="$(./scripts/version.sh)"

# Cache commit metadata.
. ./scripts/release/check_commit_metadata.sh "$old_version" "$ref"

if [[ $CODER_DRY_RUN != *t* ]]; then
# This will fail if we're doing a non-dry-run without tag
# being present.
version="$(./scripts/version.sh)"
else
if [[ $CODER_DRY_RUN == *t* ]]; then
# Create a tag for this dry-run (local only, can't be uploaded).
version="$(
./scripts/release/tag_version.sh \
Expand Down