chore: move winget publish into release pipeline #5728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jan 16, 2023
| # we do it again to be safe. | ||
| $version = "${{ needs.release.outputs.version }}".Trim('v') | ||
|
|
||
| $release_assets = gh release view --repo coder/coder "v${version}" --json assets | ` |
There was a problem hiding this comment.
Pro tip: gh builtin jq is pretty neat in these situations:
gh release view --repo coder/coder v0.14.2 --json assets --jq '.assets[] | select(.name | test("_windows_amd64_installer.exe$")) | .url'TBH the pwsh script is pretty neat too.
|
This is cleaner and looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current winget publish workflow is separate to the release which results in a lot of Tomfoolery when trying to get the version of the last release. This moves the winget publish step to a second job in the release workflow that depends on the release job, using an output from the release job to get the version.
cc: @matifali