feat: add etag to slim binaries endpoint #5750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jan 17, 2023
| } | ||
|
|
||
| // Avoid DOS by using a pool, and only doing work once per file. | ||
| v, err, _ := b.sf.Do(name, func() (interface{}, error) { |
There was a problem hiding this comment.
Did I understand the logic correctly that the purpose of this is to be able to compute hashes of served binaries that were not in coder.sha1, e.g. when it's missing?
There was a problem hiding this comment.
Yep, basically. This also serves the case where we're serving directly from the site FS because the binaries weren't compressed.
There was a problem hiding this comment.
Ok, perfect. Thanks for confirming!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETagheader to the slim binary endpointIf-None-MatchandIf-Matchto the slim binary endpoint (Go'shttp.FileServerdoes this for us when we setETagfirst).ETagsandIf-None-MatchUnblocks coder/vscode-coder#23