feat: PGP sign the checksum file in releases #5757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jan 17, 2023
| @@ -214,6 +214,7 @@ jobs: | |||
| ./build/*.rpm | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| CODER_GPG_RELEASE_KEY_BASE64: ${{ secrets.CODER_GPG_RELEASE_KEY_BASE64 }} | |||
There was a problem hiding this comment.
Just curious, why base64 vs armored?
There was a problem hiding this comment.
It's armored and base64'd. Base64'd mostly so it's on a single line. It's not necessary, but avoids any weird escaping issues if they ever crop up in the future.
|
Just realized I didn't see if we upload the file as well, or is it automatic as part of all-files-in-a-dir? |
|
Yep, the publish script automatically uploads all files in |
kylecarbs
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
coder_${version}_checksums.txt.ascto releases. Signed with the release key, for which the public key can be found inrelease.key.Kyle made the key and added it to GitHub Actions secrets. He will be adding it to 1password and sharing it with Ammar so we don't lose it and it stays secure.