feat: Pre-fill param inputs with query string values #5758

BrunoQuaresma · 2023-01-17T19:18:41Z

code-asher

Works great! One thing I noticed is that in the create form we label the fields var.{name} and in the URL it uses param.{name}, is that OK? I am not super familiar with Terraform vars so this might make sense. all good, see below

code-asher · 2023-01-17T22:02:54Z

Nevermind, I see this was discussed in the original issue. Looks good!

feat: Pre-fill param inputs with query string values

2e2a069

BrunoQuaresma requested a review from bpmct January 17, 2023 19:18

BrunoQuaresma self-assigned this Jan 17, 2023

BrunoQuaresma requested a review from a team as a code owner January 17, 2023 19:18

BrunoQuaresma requested review from code-asher and removed request for a team January 17, 2023 19:18

code-asher approved these changes Jan 17, 2023

View reviewed changes

BrunoQuaresma enabled auto-merge (squash) January 17, 2023 22:08

BrunoQuaresma merged commit a13614e into main Jan 17, 2023

BrunoQuaresma deleted the bq/support-pre-fill-parmas-for-workspace-page branch January 17, 2023 22:56

github-actions bot locked and limited conversation to collaborators Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Pre-fill param inputs with query string values #5758

feat: Pre-fill param inputs with query string values #5758

BrunoQuaresma commented Jan 17, 2023

code-asher left a comment •

edited

Loading

code-asher commented Jan 17, 2023 •

edited

Loading

feat: Pre-fill param inputs with query string values #5758

feat: Pre-fill param inputs with query string values #5758

Conversation

BrunoQuaresma commented Jan 17, 2023

code-asher left a comment • edited Loading

Choose a reason for hiding this comment

code-asher commented Jan 17, 2023 • edited Loading

code-asher left a comment •

edited

Loading

code-asher commented Jan 17, 2023 •

edited

Loading