Skip to content

feat: add --experiments flag #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 18, 2023
Merged

feat: add --experiments flag #5767

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
76c7b91
feat: support multiple values for --experimental
johnstcn Jan 16, 2023
626d81b
develop.sh: allow passing additional args to backend API via -- arg1=…
johnstcn Jan 18, 2023
d93a373
fix swaggerparser test
johnstcn Jan 18, 2023
e82c306
make fmt
johnstcn Jan 18, 2023
047771c
require AuthN on /api/v2/experiments
johnstcn Jan 18, 2023
3ba27ea
fixup! require AuthN on /api/v2/experiments
johnstcn Jan 18, 2023
3ebb778
fix nits
johnstcn Jan 18, 2023
2aeb93e
add type alias for codersdk.Experiment
johnstcn Jan 18, 2023
53d92d7
make it clear that Entitlements.Experimental is deprecated
johnstcn Jan 18, 2023
ef0cbc3
remove unnecessary types as they are now autogenerated
johnstcn Jan 18, 2023
8fdb21b
apply suggestions from code review
johnstcn Jan 18, 2023
0cb9a6a
fixup! apply suggestions from code review
johnstcn Jan 18, 2023
44e9638
warn about dragons
johnstcn Jan 18, 2023
6c32aa5
fix apidoc type
johnstcn Jan 18, 2023
1cbaaf7
codersdk.Experiments no longer needs be flaggable or special-cased in…
johnstcn Jan 18, 2023
67d07f3
lower-case when ingesting and comparing experiments
johnstcn Jan 18, 2023
196b263
update apitypings unit tests
johnstcn Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
warn about dragons
  • Loading branch information
@johnstcn
johnstcn committed Jan 18, 2023
commit 44e963854a51e106b75552c15ff1d7518b338cc9
20 changes: 13 additions & 7 deletions coderd/coderd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import (
"github.com/coder/coder/coderd/telemetry"
"github.com/coder/coder/coderd/tracing"
"github.com/coder/coder/coderd/updatecheck"
"github.com/coder/coder/coderd/util/slice"
"github.com/coder/coder/coderd/wsconncache"
"github.com/coder/coder/codersdk"
"github.com/coder/coder/provisionerd/proto"
Expand Down Expand Up @@ -220,7 +221,7 @@ func New(options *Options) *API {
},
metricsCache: metricsCache,
Auditor: atomic.Pointer[audit.Auditor]{},
Experiments: initExperiments(options.DeploymentConfig.Experiments.Value, options.DeploymentConfig.Experimental.Value),
Experiments: initExperiments(options.Logger, options.DeploymentConfig.Experiments.Value, options.DeploymentConfig.Experimental.Value),
}
if options.UpdateCheckOptions != nil {
api.updateChecker = updatecheck.New(
Expand Down Expand Up @@ -763,20 +764,25 @@ func (api *API) CreateInMemoryProvisionerDaemon(ctx context.Context, debounce ti
}

// nolint:revive
func initExperiments(raw []string, legacyAll bool) codersdk.Experiments {
exp := make([]codersdk.Experiment, 0, len(raw))
func initExperiments(log slog.Logger, raw []string, legacyAll bool) codersdk.Experiments {
exps := make([]codersdk.Experiment, 0, len(raw))
for _, v := range raw {
switch v {
case "*":
exp = append(exp, codersdk.ExperimentsAll...)
exps = append(exps, codersdk.ExperimentsAll...)
default:
exp = append(exp, codersdk.Experiment(v))
ex := codersdk.Experiment(v)
if !slice.Contains(codersdk.ExperimentsAll, ex) {
log.Warn(context.Background(), "🐉 HERE BE DRAGONS: opting into hidden experiment", slog.F("experiment", ex))
}
exps = append(exps, ex)
}
}

// --experiments takes precedence over --experimental. It's deprecated.
if legacyAll && len(raw) == 0 {
exp = append(exp, codersdk.ExperimentsAll...)
log.Warn(context.Background(), "--experimental is deprecated, use --experiments='*' instead")
exps = append(exps, codersdk.ExperimentsAll...)
}
return exp
return exps
}