fix: comment on winget PR correctly #5789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jan 19, 2023
|
|
||
| - name: Comment on PR | ||
| if: ${{ !inputs.dry_run }} | ||
| run: | | ||
| # Find the PR that wingetcreate just made. | ||
| $version = "${{ needs.release.outputs.version }}".Trim('v') | ||
| $pr_list = gh pr list --repo microsoft/winget-pkgs --search "author:cdrci Coder.Coder version ${version}" --limit 1 --json number | ` |
There was a problem hiding this comment.
Should this backtick at the end be removed too?
There was a problem hiding this comment.
Backtick is the equivalent of \ at the end of the line in powershell, so this is intentional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual winget publish code worked properly, but the comment to ping @matfiali and I didn't work because of a extraneous backtick.
The automatically created PR for reference: microsoft/winget-pkgs#94220
(I manually commented on the PR using the account from my browser to agree to the CLA)