Skip to content

chore(site): align ESLint config to typescript-eslint's recommended-requiring-type-checking #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023
Merged

chore(site): align ESLint config to typescript-eslint's recommended-requiring-type-checking #5797

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1bf93a
chore(site): align ESLint config to typescript-eslint's recommended-r…
JoshuaKGoldberg Jan 19, 2023
5727a88
Fixed immediately fixable rules, and TODO-diabled the rest
JoshuaKGoldberg Jan 19, 2023
9efca7a
Merge branch 'main'
JoshuaKGoldberg Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(site): align ESLint config to typescript-eslint's recommended-r… 
…equiring-type-checking
  • Loading branch information
@JoshuaKGoldberg
JoshuaKGoldberg committed Jan 19, 2023
commit c1bf93a41a50347b48994c552e79d1a74b05b7b1
12 changes: 1 addition & 11 deletions site/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ env:
extends:
- eslint:recommended
- plugin:@typescript-eslint/recommended
- plugin:@typescript-eslint/recommended-requiring-type-checking
- plugin:eslint-comments/recommended
- plugin:import/recommended
- plugin:import/typescript
Expand Down Expand Up @@ -35,29 +36,18 @@ root: true
rules:
"@typescript-eslint/brace-style":
["error", "1tbs", { "allowSingleLine": false }]
"@typescript-eslint/camelcase": "off"
"@typescript-eslint/explicit-function-return-type": "off"
"@typescript-eslint/explicit-module-boundary-types": "error"
"@typescript-eslint/method-signature-style": ["error", "property"]
"@typescript-eslint/no-floating-promises": error
"@typescript-eslint/no-invalid-void-type": error
# We're disabling the `no-namespace` rule to use a pattern of defining an interface,
# and then defining functions that operate on that data via namespace. This is helpful for
# dealing with immutable objects. This is a common pattern that shows up in some other
# large TypeScript projects, like VSCode.
# More details: https://github.com/coder/m/pull/9720#discussion_r697609528
"@typescript-eslint/no-namespace": "off"
"@typescript-eslint/no-unnecessary-boolean-literal-compare": error
"@typescript-eslint/no-unnecessary-condition": warn
"@typescript-eslint/no-unnecessary-type-assertion": warn
"@typescript-eslint/no-unused-vars":
- error
- argsIgnorePattern: "^_"
varsIgnorePattern: "^_"
ignoreRestSiblings: true
"@typescript-eslint/no-use-before-define": "off"
"@typescript-eslint/object-curly-spacing": ["error", "always"]
"@typescript-eslint/triple-slash-reference": "off"
"brace-style": "off"
"curly": ["error", "all"]
"eslint-comments/require-description": "error"
Expand Down