Skip to content

feat: better display secret audit values #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Kira-Pilot
Copy link
Member

Resolves #4561

We decided to go really simple here and just match the sensitive value treatment on the workspace resource cards:
Screen Shot 2023-01-19 at 4 41 37 PM

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner January 19, 2023 21:49
@Kira-Pilot Kira-Pilot requested review from jsjoeio and removed request for a team January 19, 2023 21:49
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@Kira-Pilot Kira-Pilot merged commit a0a959c into main Jan 19, 2023
@Kira-Pilot Kira-Pilot deleted the secret-values-audit/kira-pilot branch January 19, 2023 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: find a better way to display secret values
2 participants