Skip to content

feat: Validate workspace build parameters #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
df9ddf3
WIP
mtojek Jan 18, 2023
e8e2e53
WIP
mtojek Jan 18, 2023
cfe5521
CLI: handle workspace build parameters
mtojek Jan 18, 2023
74315b2
fix: golintci
mtojek Jan 18, 2023
90b5e35
Fix: dry run
mtojek Jan 19, 2023
34db76e
fix
mtojek Jan 19, 2023
a78f798
CLI: is mutable
mtojek Jan 19, 2023
7e6ddca
coderd: mutable
mtojek Jan 19, 2023
b55e402
fix: golanci
mtojek Jan 19, 2023
f6dee95
fix: richParameterFile
mtojek Jan 19, 2023
f46cf48
CLI: create unit tests
mtojek Jan 19, 2023
40a4aa0
CLI: update test
mtojek Jan 19, 2023
1af7b9a
Fix
mtojek Jan 19, 2023
d20626a
Merge branch 'main' into 5574-cli-add-template-version-parameters
mtojek Jan 20, 2023
8c989ee
fix: order
mtojek Jan 20, 2023
6dbd044
fix
mtojek Jan 20, 2023
125d861
feat: Validate workspace build parameters
mtojek Jan 20, 2023
e278cc0
Validator tests
mtojek Jan 20, 2023
b6c3cde
WIP validation
mtojek Jan 20, 2023
5d6c547
Column: validation error
mtojek Jan 23, 2023
f655603
fix
mtojek Jan 23, 2023
1784771
Merge branch 'main' into 5574-validation-rules
mtojek Jan 23, 2023
f35ec02
merge
mtojek Jan 23, 2023
cfb1d4b
Fix
mtojek Jan 23, 2023
fc3e039
fix
mtojek Jan 23, 2023
ebddd3c
fix: default null
mtojek Jan 23, 2023
967edfc
Merge branch 'main' into 5574-validation-rules
mtojek Jan 23, 2023
cfd0330
CLI validation
mtojek Jan 23, 2023
83ddace
fmt
mtojek Jan 23, 2023
2e7c5f4
fix: default
mtojek Jan 23, 2023
f317891
Fix
mtojek Jan 23, 2023
695680e
Pull new version of terraform-provider-coder
mtojek Jan 23, 2023
1e5b776
go mod
mtojek Jan 23, 2023
fb0ee73
CLI
mtojek Jan 24, 2023
0b426b8
Fix
mtojek Jan 24, 2023
d347b68
TestCreateValidateRichParameters
mtojek Jan 24, 2023
228d806
CLI tests
mtojek Jan 24, 2023
8c5bc6b
Merge branch 'main' into 5574-validation-rules
mtojek Jan 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
mtojek committed Jan 24, 2023
commit 0b426b86a6d3fa30f0123c2782b51a55d402ed1d
8 changes: 0 additions & 8 deletions cli/cliui/parameter.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ func RichParameter(cmd *cobra.Command, templateVersionParameter codersdk.Templat
return value, nil
}

func templateVersionParameterOptionValues(param codersdk.TemplateVersionParameter) []string {
var options []string
for _, opt := range param.Options {
options = append(options, opt.Value)
}
return options
}

func validateRichPrompt(value string, p codersdk.TemplateVersionParameter) error {
return codersdk.ValidateWorkspaceBuildParameter(p, codersdk.WorkspaceBuildParameter{
Name: p.Name,
Expand Down