Skip to content

feat: add deployment-wide DAU chart #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 26, 2023
Merged

feat: add deployment-wide DAU chart #5810

Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2823b38
Add route
presleyp Jan 18, 2023
05ac9e3
Add sidebar nav item
presleyp Jan 18, 2023
541cb0b
Extract DAUChart
presleyp Jan 18, 2023
bf011ac
Set up chart with mock data
presleyp Jan 18, 2023
1758c30
Handle error
presleyp Jan 18, 2023
db938fc
Format
presleyp Jan 18, 2023
9097d80
Format
presleyp Jan 18, 2023
7979231
Add route
presleyp Jan 18, 2023
057d750
Add query
presleyp Jan 18, 2023
1c94129
Add to metrics cache
presleyp Jan 19, 2023
bd7d19d
Add db fake
presleyp Jan 19, 2023
ecb434b
Connect BE and FE
presleyp Jan 20, 2023
782c168
Add test
presleyp Jan 20, 2023
ea8aa67
Remove comment
presleyp Jan 20, 2023
94f5f39
Change response type name
presleyp Jan 20, 2023
cd4a3bf
Add stories
presleyp Jan 20, 2023
882169e
Add page title
presleyp Jan 20, 2023
11f6c40
Merge branch 'main' into 5751/deployment-dau/presleyp
presleyp Jan 20, 2023
f1a29c1
Move DAUs to General Settings for now
presleyp Jan 20, 2023
4ce7df9
Add annotation
presleyp Jan 20, 2023
99bbf4f
Update coderd/metricscache/metricscache.go
presleyp Jan 23, 2023
88ecbae
Go fixes
presleyp Jan 23, 2023
fedb39c
Merge branch '5751/deployment-dau/presleyp' of github.com:coder/coder…
presleyp Jan 23, 2023
20390ce
Fix annotation
presleyp Jan 23, 2023
263e7e5
Merge branch 'main' into 5751/deployment-dau/presleyp
presleyp Jan 23, 2023
afe43ae
Make gen
presleyp Jan 23, 2023
19ba5f6
Merge branch 'main' of github.com:coder/coder into 5751/deployment-da…
BrunoQuaresma Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions coderd/metricscache/metricscache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,7 @@ func (c *Cache) Close() error {

func (c *Cache) DeploymentDAUs() (*codersdk.DeploymentDAUsResponse, bool) {
m := c.deploymentDAUResponses.Load()
if m == nil {
// Data loading.
return nil, false
}

resp := *m
return &resp, true
return m, m != nil
}

// TemplateDAUs returns an empty response if the template doesn't have users
Expand Down