Skip to content

feat: indicate when workspace builds are stopped/started by Coder #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2023
Merged

feat: indicate when workspace builds are stopped/started by Coder #5813

merged 4 commits into from
Jan 23, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves part of #4729. We now indicate the build reason in the workspace_build audit logs:
Screen Shot 2023-01-20 at 4 41 46 PM

Still need to add the ability to filter.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner January 20, 2023 21:47
@Kira-Pilot Kira-Pilot requested review from jsjoeio and removed request for a team January 20, 2023 21:47
@Kira-Pilot Kira-Pilot changed the title Label build events/kira pilot feat: indicate when workspace_builds are stopped/started by Coder Jan 20, 2023
@Kira-Pilot Kira-Pilot requested review from Emyrk, a team and coadler January 20, 2023 21:48
@Kira-Pilot Kira-Pilot changed the title feat: indicate when workspace_builds are stopped/started by Coder feat: indicate when workspace builds are stopped/started by Coder Jan 20, 2023
jsjoeio
jsjoeio approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Emyrk
Emyrk reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, overall LGTM

@Kira-Pilot Kira-Pilot merged commit 443e218 into main Jan 23, 2023
@Kira-Pilot Kira-Pilot deleted the label-build-events/kira-pilot branch January 23, 2023 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk left review comments

@jsjoeio jsjoeio jsjoeio approved these changes

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kira-Pilot @jsjoeio @Emyrk @coadler