Skip to content

chore: agent_test.go: use ptty.Peek() instead of expecting caret in TestAgent_SessionTTYShell #5821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

chore: agent_test.go: use ptty.Peek() instead of expecting caret in TestAgent_SessionTTYShell #5821

merged 1 commit into from
Jan 23, 2023

Conversation

johnstcn
Copy link
Member

This stops the test breaking if your fancy prompt doesn't end with a $.

@johnstcn johnstcn requested a review from mafredri January 23, 2023 11:09
@johnstcn johnstcn self-assigned this Jan 23, 2023
@johnstcn johnstcn merged commit 73afdd7 into main Jan 23, 2023
@johnstcn johnstcn deleted the cj/testagent-sessionttyshell-peek branch January 23, 2023 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri