Skip to content

fix: routinely ping agent websocket to ensure liveness #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2023
Merged

fix: routinely ping agent websocket to ensure liveness #5824

merged 4 commits into from
Jan 23, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jan 23, 2023

There seems to be a sneaky websocket bug when behind GCP load balancers. I've noticed that sometimes when cycling a coder server VM behind a GCP load balancer the websocket can hang trying to read, which prevents it from reconnecting to the new coder server.

@coadler coadler self-assigned this Jan 23, 2023
kylecarbs
kylecarbs approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this with all of our websockets?

@coadler coadler enabled auto-merge (squash) January 23, 2023 19:53
@coadler coadler merged commit d2ae16d into main Jan 23, 2023
@coadler coadler deleted the colin/coordinate-ws-ping branch January 23, 2023 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @deansheather