Skip to content

fix: ensure agent websocket only removes its own conn #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2023
Merged

fix: ensure agent websocket only removes its own conn #5828

merged 4 commits into from
Jan 23, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jan 23, 2023

No description provided.

@coadler coadler requested a review from kylecarbs January 23, 2023 21:39
@coadler coadler self-assigned this Jan 23, 2023
kylecarbs
kylecarbs approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we compare the pointer instead?

@coadler
Copy link
Contributor Author

coadler commented Jan 23, 2023

I think we could, but imo this is a bit clearer.

@kylecarbs
Copy link
Member

An advantage of not is less allocation, even if slight.

@coadler coadler changed the title fix: ensure agent websocket only removes its own conn from the map fix: ensure agent websocket only removes its own conn Jan 23, 2023
@coadler coadler merged commit c3731a1 into main Jan 23, 2023
@coadler coadler deleted the colin/fix-coordinator-race branch January 23, 2023 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @kylecarbs