Skip to content

chore: remove code-server release limitation and add image push policy in kubernetes example template #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 30, 2023
Merged

chore: remove code-server release limitation and add image push policy in kubernetes example template #5831

merged 6 commits into from
Jan 30, 2023

Conversation

sharkymark
Copy link
Contributor

This PR:

  1. Removes old release hard-coded into code-server install - now grabs latest
  2. Removes .profile and .bashrc logic which is an opinion, and not generic
  3. Adds image_pull_policy of Always to pod spec since Coder enterprise-base image tag is not latest and there Terraform by default does not check tag hash changes - without this change, old versions of the Coder base image could persist with vulnerabilities

@sharkymark sharkymark removed the request for review from bpmct January 30, 2023 02:21
@ericpaulsen ericpaulsen merged commit 91ef8d9 into main Jan 30, 2023
@ericpaulsen ericpaulsen deleted the example-code-server branch January 30, 2023 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@ericpaulsen ericpaulsen ericpaulsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharkymark @kylecarbs @ericpaulsen