Skip to content

fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready #5850

merged 3 commits into from
Jan 25, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 25, 2023 •
edited
Loading

Refs: #5835, #5749

@mafredri mafredri self-assigned this Jan 25, 2023
@mafredri mafredri mentioned this pull request Jan 25, 2023
Closed
13 tasks
@mafredri mafredri marked this pull request as ready for review January 25, 2023 10:36
mafredri
mafredri commented Jan 25, 2023
View reviewed changes
BrunoQuaresma
BrunoQuaresma approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just check if the screenshots in Chromatic checks are the expected results

@mafredri
Copy link
Member Author

Looks good to me. Just check if the screenshots in Chromatic checks are the expected results

@BrunoQuaresma the only changes I see is build progress bar. There are no changes to the agent status and this is what I'd expect since the mocked values have delay_login_until_ready: true.

@BrunoQuaresma
Copy link
Collaborator

@mafredri I have to fix this on storybook but it looks good to go.

@mafredri mafredri merged commit 5c5ddc6 into main Jan 25, 2023
@mafredri mafredri deleted the mafredri/fix-hide-agent-lifecycle-status-unless-optin branch January 25, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @BrunoQuaresma