fix: loop variable captured by func literal in parameters test #5878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when adding a new parameter type. There's a test case for an empty string that returned false for validation, but appears like it could be true. If there is no value for a string, then the default is used. In this case there is no default, but that's technically fine I believe.
mtojek
approved these changes
Jan 27, 2023
| @@ -900,7 +900,7 @@ func TestWorkspaceBuildValidateRichParameters(t *testing.T) { | |||
| {numberParameterName, "10", true, numberRichParameters}, | |||
| {numberParameterName, "11", false, numberRichParameters}, | |||
|
|
|||
| {stringParameterName, "", false, stringRichParameters}, | |||
| {stringParameterName, "", true, stringRichParameters}, | |||
There was a problem hiding this comment.
I suspect that what happens here is that the parameter is ignored by API as it's "", hence it doesn't fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when adding a new parameter type. There's a test case for an empty string that returned false for validation, but appears like it could be true.
If there is no value for a string, then the default is used. In this case there is no default, but that's technically fine I believe.