Skip to content

chore: Invert delay_login_until_ready, now login_before_ready #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 27, 2023
Merged

chore: Invert delay_login_until_ready, now login_before_ready #5893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
57e130f
chore: Invert `delay_login_until_ready`, now `login_before_ready`
mafredri Jan 27, 2023
4d5b065
fixup! chore: Invert `delay_login_until_ready`, now `login_before_ready`
mafredri Jan 27, 2023
e27812c
fixup! chore: Invert `delay_login_until_ready`, now `login_before_ready`
mafredri Jan 27, 2023
ebf8a0d
Add lifecycle states to tests
mafredri Jan 27, 2023
4937ba0
Fix spinner
mafredri Jan 27, 2023
1289923
Merge branch 'main' into mafredri/chore-invert-delay_login_until_read…
mafredri Jan 27, 2023
d9fb8c6
Fix clidocgen
mafredri Jan 27, 2023
724fdf4
Fix clidocgen^2
mafredri Jan 27, 2023
b0d09fc
Fix default value for login before ready from tf
mafredri Jan 27, 2023
d903d78
Test
mafredri Jan 27, 2023
2f4bbf7
Fix tests
mafredri Jan 27, 2023
5db806f
fixup! Fix tests
mafredri Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add lifecycle states to tests
  • Loading branch information
@mafredri
mafredri committed Jan 27, 2023
commit ebf8a0d13071759a57595d819334d07b57189e67
4 changes: 4 additions & 0 deletions cli/cliui/resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestWorkspaceResources(t *testing.T) {
Agents: []codersdk.WorkspaceAgent{{
Name: "dev",
Status: codersdk.WorkspaceAgentConnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleCreated,
Architecture: "amd64",
OperatingSystem: "linux",
}},
Expand Down Expand Up @@ -60,6 +61,7 @@ func TestWorkspaceResources(t *testing.T) {
Agents: []codersdk.WorkspaceAgent{{
CreatedAt: database.Now().Add(-10 * time.Second),
Status: codersdk.WorkspaceAgentConnecting,
LifecycleState: codersdk.WorkspaceAgentLifecycleCreated,
Name: "dev",
OperatingSystem: "linux",
Architecture: "amd64",
Expand All @@ -70,12 +72,14 @@ func TestWorkspaceResources(t *testing.T) {
Name: "dev",
Agents: []codersdk.WorkspaceAgent{{
Status: codersdk.WorkspaceAgentConnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleReady,
Name: "go",
Architecture: "amd64",
OperatingSystem: "linux",
}, {
DisconnectedAt: &disconnected,
Status: codersdk.WorkspaceAgentDisconnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleReady,
Name: "postgres",
Architecture: "amd64",
OperatingSystem: "linux",
Expand Down
6 changes: 5 additions & 1 deletion cmd/cliui/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ func main() {
Use: "agent",
RunE: func(cmd *cobra.Command, args []string) error {
agent := codersdk.WorkspaceAgent{
Status: codersdk.WorkspaceAgentDisconnected,
Status: codersdk.WorkspaceAgentDisconnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleReady,
}
go func() {
time.Sleep(3 * time.Second)
Expand Down Expand Up @@ -203,6 +204,7 @@ func main() {
Agents: []codersdk.WorkspaceAgent{{
CreatedAt: database.Now().Add(-10 * time.Second),
Status: codersdk.WorkspaceAgentConnecting,
LifecycleState: codersdk.WorkspaceAgentLifecycleCreated,
Name: "dev",
OperatingSystem: "linux",
Architecture: "amd64",
Expand All @@ -213,12 +215,14 @@ func main() {
Name: "dev",
Agents: []codersdk.WorkspaceAgent{{
Status: codersdk.WorkspaceAgentConnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleReady,
Name: "go",
Architecture: "amd64",
OperatingSystem: "linux",
}, {
DisconnectedAt: &disconnected,
Status: codersdk.WorkspaceAgentDisconnected,
LifecycleState: codersdk.WorkspaceAgentLifecycleReady,
Name: "postgres",
Architecture: "amd64",
OperatingSystem: "linux",
Expand Down