Skip to content

chore: merge codeql checks to run in parallel #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 29, 2023
Merged

chore: merge codeql checks to run in parallel #5907

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7fcf376
chore: merge codeql checks to run in parallel
kylecarbs Jan 29, 2023
0ccc7b6
fix: close reconnecting pty conn when exiting agent
kylecarbs Jan 29, 2023
77997b4
Merge branch 'trackconpty' into mergesecurity
kylecarbs Jan 29, 2023
7429987
Fix closing when agent fails
kylecarbs Jan 29, 2023
18679ae
Fix conpty
kylecarbs Jan 29, 2023
ee94351
Fix contrib
kylecarbs Jan 29, 2023
9ea18e4
Skip runner tests for being flakes
kylecarbs Jan 29, 2023
09ac2ba
Fix gpg key test
kylecarbs Jan 29, 2023
17234c4
Fix golden files
kylecarbs Jan 29, 2023
64993a0
Fix comments
kylecarbs Jan 29, 2023
6f197f0
Merge branch 'trackconpty' into mergesecurity
kylecarbs Jan 29, 2023
c348aa4
Fix closed
kylecarbs Jan 29, 2023
7584a03
Merge branch 'main' into mergesecurity
kylecarbs Jan 29, 2023
b6565db
Fix capitalized title
kylecarbs Jan 29, 2023
849a9e2
Add a timeout when checking for dead links
kylecarbs Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: close reconnecting pty conn when exiting agent 
Fixes https://github.com/coder/coder/actions/runs/4038282899/jobs/6942170850
  • Loading branch information
@kylecarbs
kylecarbs committed Jan 29, 2023
commit 0ccc7b63ccba6b2bf6c4782acc8e5bdd44869763
13 changes: 11 additions & 2 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,14 @@ func (a *agent) createTailnet(ctx context.Context, derpMap *tailcfg.DERPMap) (_
logger.Debug(ctx, "accept pty failed", slog.Error(err))
return
}
closed := make(chan struct{})
_ = a.trackConnGoroutine(func() {
select {
case <-network.Closed():
case <-closed:
}
_ = conn.Close()
})
// This cannot use a JSON decoder, since that can
// buffer additional data that is required for the PTY.
rawLen := make([]byte, 2)
Expand All @@ -455,9 +463,10 @@ func (a *agent) createTailnet(ctx context.Context, derpMap *tailcfg.DERPMap) (_
if err != nil {
continue
}
go func() {
_ = a.trackConnGoroutine(func() {
defer close(closed)
_ = a.handleReconnectingPTY(ctx, logger, msg, conn)
}()
})
}
}); err != nil {
return nil, err
Expand Down