-
Notifications
You must be signed in to change notification settings - Fork 886
feat: Add initial AuthzQuerier implementation #5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jan 30, 2023
johnstcn
reviewed
Jan 30, 2023
johnstcn
reviewed
Jan 30, 2023
johnstcn
reviewed
Jan 30, 2023
Emyrk
commented
Jan 30, 2023
…kspaceAppsByAgentID
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This adds the initial AuthzQuerier implementation as an experiment. It has negative latency impacts to the api at this point, but it is correct* (bugs not withstanding).
The goal of this PR is to push a working implementation.
Testing
Prior to this PR we used
AuthorizeAllEndpoints
as our rbac assertions. This was weak (see #5204). There is a similar unit test inauthzquery
that asserts all interface methods have been tested with the proper rbac checks:coder/coderd/authzquery/methods_test.go
Line 69 in e6d5c2f
So we can remove these tests in a future PR:
coder/coderd/coderdtest/authorize.go
Line 28 in e6d5c2f
coder/coderd/coderdtest/authorize_test.go
Line 10 in e6d5c2f
coder/enterprise/coderd/coderdenttest/coderdenttest_test.go
Line 24 in e6d5c2f
Fixes #5204
Future Work
In no particular order
Refactor AuthzStore to not be 1:1 withdb.Store
. Make a new interface for it.coder/coderd/database/modelmethods.go
Lines 104 to 106 in 4e6b43f
Optimizations
workspaceData
in this layer.