lint

coder · Kira-Pilot · Feb 6, 2023 · Jan 30, 2023 · Jan 30, 2023 · Jan 30, 2023
commit 9bfc125df00cb627ba08b8fe0e27a1eb8c7584f0
diff --git a/coderd/audit/request.go b/coderd/audit/request.go
@@ -141,14 +141,12 @@ func InitRequest[T Auditable](w http.ResponseWriter, p *RequestParams) (*Request
 
 		// If no resources were provided, there's nothing we can audit.
 		if ResourceID(req.Old) == uuid.Nil && ResourceID(req.New) == uuid.Nil {
-			if req.params.Action == database.AuditActionLogin ||
-				req.params.Action == database.AuditActionLogout {
-				// If the request action is a login or logout, we always want to audit it even if
-				// there is no diff. This is so we can capture events where an API Key is never created
-				// because an unknown user fails to login.
-				// TODO: introduce the concept of an anonymous user so we always have a userID even
-				// when dealing with a mystery user. https://github.com/coder/coder/issues/6054
-			} else {
+			// If the request action is a login or logout, we always want to audit it even if
+			// there is no diff. This is so we can capture events where an API Key is never created
+			// because an unknown user fails to login.
+			// TODO: introduce the concept of an anonymous user so we always have a userID even
+			// when dealing with a mystery user. https://github.com/coder/coder/issues/6054
+			if req.params.Action != database.AuditActionLogin && req.params.Action != database.AuditActionLogout {
 				return
 			}
 		}