Skip to content

feat: add ability to deploy extra k8s yamls with helm chart #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2023
Merged

feat: add ability to deploy extra k8s yamls with helm chart #5942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75c0d52
add ability to deploy extra k8s yamls with helm chart
mh013370 Feb 1, 2023
dad39d3
Apply suggestions from code review
deansheather Feb 3, 2023
bdd7ef3
chore: correct example
deansheather Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@deansheather
deansheather authored Feb 3, 2023
commit dad39d3fafd54baf683f4714cf1fe1cf4347d7f4
6 changes: 3 additions & 3 deletions helm/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,11 @@ Deprecated value coder.tls.secretName must not be used.
{{- end }}

{{/*
Renders a value that contains template.
Renders a value that contains a template.
Usage:
{{ include "common.tplvalues.render" ( dict "value" .Values.path.to.the.Value "context" $) }}
{{ include "coder.renderTemplate" ( dict "value" .Values.path.to.the.Value "context" $) }}
*/}}
{{- define "common.tplvalues.render" -}}
{{- define "coder.renderTemplate" -}}
{{- if typeIs "string" .value }}
{{- tpl .value .context }}
{{- else }}
Expand Down
4 changes: 2 additions & 2 deletions helm/templates/extra-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range .Values.extraDeploy }}
{{- range .Values.extraTemplates }}
---
{{ include "common.tplvalues.render" (dict "value" . "context" $) }}
{{ include "coder.renderTemplate" (dict "value" . "context" $) }}
{{- end }}
8 changes: 5 additions & 3 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,14 @@ coder:
# use for the wildcard host.
wildcardSecretName: ""

# extraDeploy -- Array of extra objects to deploy with the release (evaluated as a template)
extraDeploy:
# extraTemplates -- Array of extra objects to deploy with the release. These
# are evaluated as a template and can use template expansions and functions.
# Strings are used as is, and all other objects are used as yaml.
extraTemplates:
[]
# - apiVersion: v1
# kind: ConfigMap
# metadata:
# name: my-configmap
# data:
# key: value
# key: {{ .Values.myCustomvalue | quote }}