Skip to content

Revert "refactor(docs): Change console to shell and remove unused elements" #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Revert "refactor(docs): Change console to shell and remove unused elements" #5964

merged 1 commit into from
Feb 1, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Reverts #5960

After talking with @deansheather I don't think this is a good choice anymore.

@BrunoQuaresma BrunoQuaresma self-assigned this Feb 1, 2023
bpmct
bpmct reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which one should we use consistently?

@BrunoQuaresma
Copy link
Collaborator Author

@bpmct console for inputs, and shell for outputs from what I'm understanding.

@BrunoQuaresma BrunoQuaresma merged commit 8ef0306 into main Feb 1, 2023
@BrunoQuaresma BrunoQuaresma deleted the revert-5960-bq/update-docs branch February 1, 2023 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

@deansheather deansheather deansheather approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @deansheather @bpmct