refactor(site): Add more info on agent outdated tooltip and update action #5967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Feb 1, 2023
Kira-Pilot
reviewed
Feb 1, 2023
| This agent is an older version than the Coder server. This can | ||
| happen after you update Coder with running workspaces. To fix | ||
| this, you can stop and start the workspace. | ||
| </HelpTooltipText> |
Kira-Pilot
approved these changes
Feb 1, 2023
mafredri
approved these changes
Feb 2, 2023
| onClick={onUpdate} | ||
| ariaLabel="Update workspace" | ||
| > | ||
| Update workspace |
There was a problem hiding this comment.
Should we add a warning that this will restart the workspace and running applications will be terminated? (Or something along those lines.)
There was a problem hiding this comment.
I think it is a good idea but I think it is "common sense" that updating something will turn it off. We have other parts on the app we could use this warning to warn users about update actions (or actions that terminate the workspace) so, to make this work worth it, I would wait for users to ask for that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now:
Before:
Fix #5393 and #5432