Skip to content

fix: open terminal and coder_app in a new tab, not window #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2023
Merged

fix: open terminal and coder_app in a new tab, not window #6044

merged 2 commits into from
Feb 6, 2023

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Feb 6, 2023 •
edited
Loading

This is will change the current behavior change, but I think it improves the UX a bit. Personally, I always cntrl+click to open it as a tab.

Open to thoughts though. Fixes #4950

@bpmct bpmct requested review from sharkymark and ammario February 6, 2023 05:37
@bpmct bpmct merged commit a655f03 into main Feb 6, 2023
@bpmct bpmct deleted the newtabtime branch February 6, 2023 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

@sharkymark sharkymark Awaiting requested review from sharkymark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open all coder_app in a new tab, not window
2 participants
@bpmct @ammario