Skip to content

ci: Fix silent missing metadata for release notes #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2023
Merged

ci: Fix silent missing metadata for release notes #6089

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a105c9a
ci: Fix silent missing metadata for release notes
mafredri Feb 7, 2023
493b9be
Fix a few more instances of < <()
mafredri Feb 7, 2023
da80688
Fix script paths
mafredri Feb 8, 2023
f14f33a
Set GITHUB_TOKEN in release.yaml
mafredri Feb 8, 2023
51315cf
Fix from commit date
mafredri Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix script paths
  • Loading branch information
@mafredri
mafredri committed Feb 8, 2023
commit da806887e42a5c600fc48b3840bd40d0c0d9fb94
4 changes: 2 additions & 2 deletions scripts/release/generate_release_notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ if [[ -z $ref ]]; then
fi

# shellcheck source=scripts/release/check_commit_metadata.sh
source "$SCRIPT_DIR/release/check_commit_metadata.sh" "$old_version" "$ref"
source "$SCRIPT_DIR/check_commit_metadata.sh" "$old_version" "$ref"

# Sort commits by title prefix, then by date, only return sha at the end.
git_log_out="$(git log --no-merges --pretty=format:"%ct %h %s" "$old_version..$ref" | sort -k3,3 -k1,1n | cut -d' ' -f2)"
Expand Down Expand Up @@ -139,7 +139,7 @@ changelog="$(
done
)"

image_tag="$(execrelative ./image_tag.sh --version "$new_version")"
image_tag="$(execrelative ../image_tag.sh --version "$new_version")"

echo -e "## Changelog
$changelog
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/tag_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ ref=$(git rev-parse --short "$ref")

log "Checking commit metadata for changes since $old_version..."
# shellcheck source=scripts/release/check_commit_metadata.sh
source "$SCRIPT_DIR/release/check_commit_metadata.sh" "$old_version" "$ref"
source "$SCRIPT_DIR/check_commit_metadata.sh" "$old_version" "$ref"

if ((COMMIT_METADATA_BREAKING == 1)); then
prev_increment=$increment
Expand Down