Skip to content

helm: add deployment securityContext values #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023
Merged

helm: add deployment securityContext values #6136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c0a80
helm: add deployment securityContext values
ericpaulsen Feb 9, 2023
a014ae9
rm: podSecurityContext
ericpaulsen Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rm: podSecurityContext
  • Loading branch information
@ericpaulsen
ericpaulsen committed Feb 9, 2023
commit a014ae97bb8c192d5bc3e7401254f90d913f8b5f
2 changes: 0 additions & 2 deletions helm/templates/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ spec:
labels:
{{- include "coder.labels" . | nindent 8 }}
spec:
securityContext: {{ toYaml .Values.coder.podSecurityContext | nindent 8 }}
serviceAccountName: {{ .Values.coder.serviceAccount.name | quote }}
restartPolicy: Always
{{- with .Values.coder.image.pullSecrets }}
Expand All @@ -49,7 +48,6 @@ spec:
{{- with .Values.coder.initContainers }}
initContainers:
{{ toYaml . | nindent 8 }}
securityContext: {{ toYaml .Values.coder.securityContext | nindent 12 }}
{{- end }}
containers:
- name: coder
Expand Down
20 changes: 0 additions & 20 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,26 +50,6 @@ coder:
# coder.serviceAccount.name -- The service account name
name: coder

# coder.podSecurityContext -- Fields related to the pod's security context
# (as opposed to the container). Some fields are also present in the
# container security context, which will take precedence over these values.
podSecurityContext:
# coder.podSecurityContext.runAsNonRoot -- Requires that containers in
# the pod run as an unprivileged user. If setting runAsUser to 0 (root),
# this will need to be set to false.
runAsNonRoot: true
# coder.podSecurityContext.runAsUser -- Sets the user id of the pod.
# For security reasons, we recommend using a non-root user.
runAsUser: 1000
# coder.podSecurityContext.runAsGroup -- Sets the group id of the pod.
# For security reasons, we recommend using a non-root group.
runAsGroup: 1000
# coder.podSecurityContext.seccompProfile -- Sets the seccomp profile
# for the pod. If set, the container security context setting will take
# precedence over this value.
seccompProfile:
type: RuntimeDefault

# coder.securityContext -- Fields related to the container's security
# context (as opposed to the pod). Some fields are also present in the pod
# security context, in which case these values will take precedence.
Expand Down