-
Notifications
You must be signed in to change notification settings - Fork 881
feat(agent): Add shutdown lifecycle states and shutdown_script support #6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49f04ad
to
a1222d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM, but I didn't analyze it too deeply as the PR is massive.
2ac1a38
to
2ca1810
Compare
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Hey @mafredri! Is it something that you will continue to work soon? |
Yup, I'll get this rebased and (try to) merge it today. 👍🏻 |
2ca1810
to
22ad8b9
Compare
shutdown_script
support
This PR adds support for agent shutdown lifecycle states and
shutdown_script
.It (currently) relies on terraform provider abilities to gracefully shut down. For instance with the docker provider it can be controlled via:
The agent can handle common signals like
SIGHUP
,SIGINT
,SIGTERM
. If need be, more signals could be handled.Builds upon #5171
Fixes #4677
Note:
stopping
,stop_timeout
,stop_error
,stopped
, yay or nay to make this change?