Skip to content

fix: Improve use of context in websocket.NetConn code paths #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2023
Merged

fix: Improve use of context in websocket.NetConn code paths #6198

merged 3 commits into from
Feb 14, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Feb 14, 2023 •
edited
Loading

Was looking into template dry run CI flake and ended up in a rabbit hole.

    templateversions_test.go:713: 
        	Error Trace:	/home/runner/work/coder/coder/coderd/templateversions_test.go:713
        	            				/home/runner/work/coder/coder/coderd/asm_amd64.s:1598
        	Error:      	"0" is not greater than or equal to "1"
        	Test:       	TestTemplateVersionDryRun/OK
        	Messages:   	unexpected log count

Note: Can't repro locally so I can't confirm if this fixes or even helps with the issue. But in general I think these changes are good to make.

@mafredri mafredri mentioned this pull request Feb 14, 2023
Merged
@mafredri mafredri marked this pull request as ready for review February 14, 2023 14:24
@mafredri mafredri requested a review from kylecarbs February 14, 2023 14:30
@mafredri mafredri merged commit 5df7872 into main Feb 14, 2023
@mafredri mafredri deleted the mafredri/fix-websocket-net-conn-contexts branch February 14, 2023 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs