Skip to content

refactor(site): Refactor template settings #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2023
Merged

refactor(site): Refactor template settings #6239

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0312c16
Move danger zone
BrunoQuaresma Feb 16, 2023
bc56fb1
Fix links and buttons
BrunoQuaresma Feb 16, 2023
a92282d
refactor(site): Refactor template settings
BrunoQuaresma Feb 16, 2023
17598fc
Update site/src/i18n/en/templateForm.json
BrunoQuaresma Feb 16, 2023
9caa4c0
Update site/src/i18n/en/templateForm.json
BrunoQuaresma Feb 16, 2023
48bf131
Add back allow cancel jobs
BrunoQuaresma Feb 16, 2023
8b6bfcf
Add a few more tests
BrunoQuaresma Feb 17, 2023
54f9d95
Remove duplicated ttl field
BrunoQuaresma Feb 17, 2023
7c13645
Merge branch 'main' into bq/refactor-template-settings
BrunoQuaresma Feb 17, 2023
19453fd
Fix stories
BrunoQuaresma Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicated ttl field
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Feb 17, 2023
commit 54f9d95b88a1ccfde7daae7627e8857cf9ac4c5c
18 changes: 0 additions & 18 deletions site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,24 +183,6 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
/>
</FormSection>

<FormSection
title={t("schedule.title")}
description={t("schedule.description")}
>
<TextField
{...getFieldHelpers(
"default_ttl_ms",
<TTLHelperText ttl={form.values.default_ttl_ms} />,
)}
disabled={isSubmitting}
fullWidth
inputProps={{ min: 0, step: 1 }}
label={t("defaultTtlLabel")}
variant="outlined"
type="number"
/>
</FormSection>

<FormSection
title={t("operations.title")}
description={t("operations.description")}
Expand Down