Skip to content

feat(cli): make minor improvements to speedtest #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2023
Merged

feat(cli): make minor improvements to speedtest #6266

merged 6 commits into from
Feb 22, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Feb 17, 2023

  • Remove mostly redundant "Transferred" column
  • Rename "Bandwidth" to "Throughput"
  • Replace "--reverse" (which has an ambiguous starting state) with "--direction=(up|down)"
  • Tolerate AgentStartErrors which may be caused by failing startup script

@ammario
feat(cli): make minor improvements to speedtest
787e2cd 
- Remove mostly redundant "Transferred" column
- Rename "Bandwidth" to "Throughput"
- Replace "--reverse" (which has an ambiguous starting state) with "--direction=(up|down)"
- Tolerate AgentStartErrors which may be caused by failing startup
  script
@ammario ammario requested a review from deansheather February 17, 2023 20:39
@ammario ammario enabled auto-merge (squash) February 17, 2023 20:40
ammario and others added 2 commits February 17, 2023 14:49
@deansheather
Copy link
Member

To update the golden files use make update-golden-files

@ammario ammario merged commit 8231de9 into main Feb 22, 2023
@ammario ammario deleted the speedtest branch February 22, 2023 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammario @deansheather @matifali