Skip to content

feat(cli): organize flags #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

feat(cli): organize flags #6269

wants to merge 14 commits into from

Conversation

ammario
Copy link
Member

@ammario ammario commented Feb 17, 2023

Makes progress on #6055

See the golden files in the change-set to get a sense of the new format.

@ammario ammario marked this pull request as ready for review February 18, 2023 00:11
@ammario ammario requested a review from kylecarbs February 18, 2023 00:11
@bpmct
Copy link
Member

bpmct commented Feb 19, 2023

Can you change to "partially resolves?" Would love to also include the markdown presentation as part of #6055?

@ammario ammario requested a review from deansheather February 20, 2023 21:08
Co-authored-by: Dean Sheather <dean@deansheather.com>
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the net value for the user exists, so I'm fine doing it this way for now.

We should probably move away from Cobra if we want to do this instead.

@ammario ammario closed this Mar 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
@github-actions github-actions bot deleted the admin-flags branch August 22, 2023 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants