fix(site): Fix login flow #6294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const redirect_uri = encodeURIComponent(`${protocol}//${host}/login`) | ||
| // The path doesn't matter but we use /api because the dev server | ||
| // proxies /api to the backend. | ||
| const uri = `${protocol}//${appHost.host.replace( |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Kira-Pilot
reviewed
Feb 22, 2023
| <div className={styles.error}> | ||
| <AlertBanner severity="error" error={error} /> | ||
| </div> | ||
| </Maybe> |
Kira-Pilot
reviewed
Feb 22, 2023
| } | ||
|
|
||
| return permissions | ||
| throw new Error("User is not authenticated.") |
There was a problem hiding this comment.
A lot of these hooks look very similar. Perhaps down the road (not in this PR) we could consolidate them into 1 hook that takes an arg.
Kira-Pilot
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6224
login-demo-720.mov