Skip to content

docs: parameters #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

docs: parameters #6332

merged 2 commits into from
Feb 24, 2023

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Feb 23, 2023 •
edited
Loading

Keeping as a draft until #6328 is resolved. Since parameters are still under heavy iteration, I linked to the Terraform reference instead of unfolding all the options.

Resolves
Contributes to #6074

I'll also explain legacy parameters

@bpmct bpmct requested review from ammario and mtojek February 23, 2023 23:53
mtojek
mtojek approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtojek mtojek marked this pull request as ready for review February 24, 2023 00:08
ammario
ammario approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you think Parameters deserve their own page? It's a large enough concept.

@bpmct
Copy link
Member Author

bpmct commented Feb 24, 2023

Yeah, I think we should give them a page once #5980 and #6100 are complete because we can explain how parameters, variables, etc. all fit together

@bpmct bpmct merged commit 29dbfe0 into main Feb 24, 2023
@bpmct bpmct deleted the parameters-docs branch February 24, 2023 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpmct @ammario @mtojek