Skip to content

feat: add support for coder_git_auth data source #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 27, 2023
Merged

feat: add support for coder_git_auth data source #6334

merged 21 commits into from
Feb 27, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Feb 24, 2023

This allows template authors to force Git authentication on workspace creation. It does not provide guarantees of Git authentication on subsequent builds at the moment, but that might change before merge.

TODO:

  • Add validation for Git authentication in the workspace build API
  • Add prompts in the CLI for authenticating with Git

Update: I'll be adding support for forcing Git authentication during workspace builds once the startup script work @code-asher is working on is merged. Otherwise, it becomes a bit awkward.

I wasn't able to find a fantastic way to decompose this PR into smaller chunks. This only affects users that add the coder_git_auth block to their templates!

@kylecarbs kylecarbs self-assigned this Feb 24, 2023
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but nothing really concerning.

@kylecarbs kylecarbs merged commit 7f226d4 into main Feb 27, 2023
@kylecarbs kylecarbs deleted the gitauth branch February 27, 2023 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants