Skip to content

fix!: replace owner_email with workspace_owner, change action to workspace_transition #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix!: replace owner_email with workspace_owner, change action to workspace_transition #6337

merged 1 commit into from
Feb 24, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 24, 2023 •
edited
Loading

  • owner_email is problematic because prom replaces @ with _. Replacing with username (workspace_owner)
  • action -> workspace_transition for consistency

Fixes #6335.

@johnstcn johnstcn requested a review from a team February 24, 2023 04:04
@johnstcn johnstcn self-assigned this Feb 24, 2023
@johnstcn johnstcn requested review from deansheather and removed request for a team February 24, 2023 04:04
deansheather
deansheather approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this needs to be marked breaking by adding a ! to the PR title (fix!: ...) and adding the release/breaking label

@johnstcn johnstcn changed the title fix: replace owner_email with workspace_owner, change action to workspace_transition fix!: replace owner_email with workspace_owner, change action to workspace_transition Feb 24, 2023
@johnstcn johnstcn added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Feb 24, 2023
@johnstcn
Copy link
Member Author

LGTM but this needs to be marked breaking by adding a ! to the PR title (fix!: ...) and adding the release/breaking label

Done, but is this necessary even if the changed behaviour is not yet in any published release?

@johnstcn johnstcn merged commit 473ab20 into main Feb 24, 2023
@johnstcn johnstcn deleted the cj/fixup-prom-owner-email branch February 24, 2023 04:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@johnstcn johnstcn

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: prometheus: user_host.tld logged instead of user@host.tld
2 participants
@johnstcn @deansheather